Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guide): Add full solution to jQuery challenge: Use jQuery to Modify the Entire Page #35270

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

thecodingaviator
Copy link
Contributor

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

@thecodingaviator thecodingaviator changed the title fix(learn): Add full solution to jQuery challenge: Use jQuery to Modify the Entire Page fix(guide): Add full solution to jQuery challenge: Use jQuery to Modify the Entire Page Feb 18, 2019
@RandellDawson
Copy link
Member

@thecodingaviator When posting a full solution for the Guide, it should include all relative code (HTML, CSS, JS), so that a user could copy/paste and replace all the code in the editor and the code would pass.

@RandellDawson RandellDawson added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Feb 18, 2019
@thecodingaviator
Copy link
Contributor Author

@RandellDawson That goes for all guide articles, right? I was going by what the existing articles say and they had only the <script>

@RandellDawson
Copy link
Member

@thecodingaviator The guide articles you find that do not have the full code should be updated at some point. We will just fix them as we find them.

@thecodingaviator
Copy link
Contributor Author

Ahh, alright

@RandellDawson RandellDawson merged commit efe39a5 into freeCodeCamp:master Mar 1, 2019
@RandellDawson
Copy link
Member

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉

@thecodingaviator thecodingaviator deleted the patch-8 branch March 1, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants