Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed grammar/formatting of entire document #35392

Merged

Conversation

cmccormack
Copy link
Member

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.


<a href='https://www.w3schools.com/css/css_pseudo_elements.asp' target='_blank' rel='nofollow'>W3Schools CSS Pseudo-elements</a>
[See A Whole Bunch of Amazing Stuff Pseudo Elements Can Do!](https://www.w3schools.com/css/css_pseudo_elements.asp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[See A Whole Bunch of Amazing Stuff Pseudo Elements Can Do!](https://www.w3schools.com/css/css_pseudo_elements.asp)
[See A Whole Bunch of Amazing Stuff Pseudo Elements Can Do!](https://css-tricks.com/pseudo-element-roundup/)

I feel this is better and shows more variety

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find both of those links to be valid. My goal was not really to modify the content so much as clean everything up - if you'd like to submit a pull request to change that link please feel free!

@raisedadead
Copy link
Member

Hi @cmccormack @RandellDawson @thecodingaviator

I am going ahead and merging this article PR out of order. We are testing something on the Guide's client code and would need to trigger a build.

This PR seems to have some jsFiddle links that we would like to test something on.

Thanks.

@raisedadead raisedadead merged commit 52105e3 into freeCodeCamp:master Feb 26, 2019
@cmccormack cmccormack deleted the fix/cleanup-css-before-selector branch February 27, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants