Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guide): Add full solution code to jQuery challenges #35488

Merged

Conversation

thecodingaviator
Copy link
Contributor

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

In addition to adding the full solution, the PR also removes the commented line saying Add code below here to maintain uniformity in this subsection of the guide

Refer #35271

Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all solutions and they work fine.

@RandellDawson RandellDawson merged commit 058db4f into freeCodeCamp:master Mar 8, 2019
@RandellDawson
Copy link
Member

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉

@thecodingaviator thecodingaviator deleted the fix/jQueryFullSolutions branch March 9, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants