Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guide): ES6 destructuring assignment with the rest operator #35681

Merged
merged 6 commits into from Mar 29, 2019
Merged

fix(guide): ES6 destructuring assignment with the rest operator #35681

merged 6 commits into from Mar 29, 2019

Conversation

AdrianSkar
Copy link
Contributor

Minor fixes/enhancements.

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

@thecodingaviator thecodingaviator added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP scope: guide labels Mar 26, 2019
@RandellDawson RandellDawson added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Mar 26, 2019
…ructures/es6/use-destructuring-assignment-with-the-rest-operator-to-reassign-array-elements/index.md

Co-Authored-By: AdrianSkar <adrian@adrianskar.com>
thecodingaviator and others added 2 commits March 28, 2019 20:02
…ructures/es6/use-destructuring-assignment-with-the-rest-operator-to-reassign-array-elements/index.md

Co-Authored-By: AdrianSkar <adrian@adrianskar.com>
…ructures/es6/use-destructuring-assignment-with-the-rest-operator-to-reassign-array-elements/index.md

Co-Authored-By: AdrianSkar <adrian@adrianskar.com>
@RandellDawson RandellDawson removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Mar 28, 2019
@RandellDawson
Copy link
Member

@AdrianSkar Your added solution is still missing a key part:

const arr = removeFirstTwo(source);

Technically the first solution shown is also missing this same line and has the const source = [1,2,3,4,5,6,7,8,9,10]; in the wrong location. Would you mind fixing both solutions? That should be good enough to get this merged.

Thanks

Copy/paste friendly code as discussed.
@AdrianSkar
Copy link
Contributor Author

Sure, @RandellDawson, how about now?

…ructures/es6/use-destructuring-assignment-with-the-rest-operator-to-reassign-array-elements/index.md

Co-Authored-By: AdrianSkar <adrian@adrianskar.com>
Copy link
Contributor

@thecodingaviator thecodingaviator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@thecodingaviator thecodingaviator removed the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Mar 29, 2019
@RandellDawson RandellDawson merged commit 08bdc86 into freeCodeCamp:master Mar 29, 2019
@RandellDawson
Copy link
Member

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉

@AdrianSkar AdrianSkar deleted the patch-3 branch March 29, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants