Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(challenge): add .english to file name #35687

Merged
merged 1 commit into from
Mar 27, 2019
Merged

fix(challenge): add .english to file name #35687

merged 1 commit into from
Mar 27, 2019

Conversation

lasjorg
Copy link
Contributor

@lasjorg lasjorg commented Mar 26, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Adds missing .english notation to file name. Original PR #35301

@camperbot camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Mar 27, 2019
thecodingaviator
thecodingaviator approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@thecodingaviator thecodingaviator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

RandellDawson
RandellDawson approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RandellDawson RandellDawson merged commit be68797 into freeCodeCamp:master Mar 27, 2019
@RandellDawson
Copy link
Member

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉

@lasjorg lasjorg deleted the fix/challenge-use-the-value-attribute-with-radio-buttons-and-checkboxes-correct-file-name branch April 2, 2019 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandellDawson RandellDawson RandellDawson approved these changes

@thecodingaviator thecodingaviator thecodingaviator approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lasjorg @RandellDawson @thecodingaviator @camperbot