Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add solutions for Sass challenges #35777

Merged
merged 1 commit into from Apr 30, 2019

Conversation

ojeytonwilliams
Copy link
Contributor

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Contributes to #35753

@camperbot camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Apr 8, 2019
Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I could not pass one of the tests (see below) on the Apply a Style Until a Condition is Met with @while challenge, I believe it is related to issues #17629 and #34775. I have created a PR (#35935) that should resolve this problem with a slight rewrite of the challenge. I am fine merging this PR as it is now.

Your .text-1 class should have a font-size of 5px.

@ojeytonwilliams
Copy link
Contributor Author

@RandellDawson I assume it failed when you put my solution into the client, rather than npm run test. If so, yeah, it's probably the browser issue raising its head again. It does look like your PR should put a stop to it, though.

Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing @ojeytonwilliams!

@moT01 moT01 merged commit e3529a8 into freeCodeCamp:master Apr 30, 2019
@ojeytonwilliams ojeytonwilliams deleted the fix/add-sass-solutions branch September 17, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants