Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): Change wording to talk about inheritance not cascade #36110

Merged
merged 1 commit into from Jun 9, 2019
Merged

fix(curriculum): Change wording to talk about inheritance not cascade #36110

merged 1 commit into from Jun 9, 2019

Conversation

ojeytonwilliams
Copy link
Contributor

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

The challenge Basic CSS: Cascading CSS variables mixes up the concepts of inheritance and cascade. I rewrote things in terms of inheritance and, hopefully, clarified some of the wording.

Closes #36108

@ojeytonwilliams ojeytonwilliams requested a review from a team May 22, 2019 16:13
@camperbot camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels May 22, 2019
moT01
moT01 approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ojeytonwilliams! 🎉

raisedadead
raisedadead approved these changes Jun 9, 2019
View reviewed changes
Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform code LGTM

@RandellDawson RandellDawson merged commit 43fa451 into freeCodeCamp:master Jun 9, 2019
@RandellDawson
Copy link
Member

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉

@ojeytonwilliams ojeytonwilliams deleted the fix/css-cascade-to-inherit branch September 17, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raisedadead raisedadead raisedadead approved these changes

@RandellDawson RandellDawson RandellDawson approved these changes

@moT01 moT01 moT01 approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cascading Css Variables
5 participants
@ojeytonwilliams @RandellDawson @raisedadead @moT01 @camperbot