Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update translation counting-sort #36536

Merged
merged 2 commits into from Aug 8, 2019

Conversation

CleoAguiar
Copy link
Contributor

added implementation codes

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

added implementation codes
RandellDawson
RandellDawson previously approved these changes Aug 8, 2019
@RandellDawson RandellDawson dismissed their stale review August 8, 2019 00:04

Has merge conflict which needs to be resolved

@RandellDawson RandellDawson added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Aug 8, 2019
@RandellDawson
Copy link
Member

@CleoAguiar Thank you for creating this PR. However, since it was created, the underlying document has changed. Can you please review and resolve the current merge conflicts? It could be the changes to the underlying document are so significant that your changes are no longer relevant. If the latter is the case, it might be easier to just close this PR and create a new PR with any changes you still feel are important to make.

If you need any assistance or have questions about resolving the merge conflicts, please reply back or contact someone in the Contributors Room on Gitter.

Thank you.

@RandellDawson RandellDawson added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Aug 8, 2019
@RandellDawson RandellDawson removed status: merge conflict To be applied to PR's that have a merge conflict and need updating status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Aug 8, 2019
@RandellDawson
Copy link
Member

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉

@RandellDawson RandellDawson merged commit 5204933 into freeCodeCamp:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants