Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution should include return keys of any object passed to the function, not just the "users" object in generate-an-array-of-all-object-keys-with-object.keys.english.md #36578

Merged
merged 1 commit into from Aug 11, 2019

Conversation

joelzehring
Copy link
Contributor

Method should act on any passed parameter rather than the specific object named in this problem.

  • [ x] I have read freeCodeCamp's contribution guidelines.
  • [ x] My pull request has a descriptive title (not a vague title like Update index.md)
  • [ x] My pull request targets the master branch of freeCodeCamp.
  • [ x] None of my changes are plagiarized from another source without proper attribution.
  • [ x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • [ x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

Method should act on any passed parameter rather than the specific object named in this problem.
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @joelzehring - congratulations on your first contribution to freeCodeCamp! 🎉

We look forward to future contributions - thanks and happy coding! 🎉

@moT01 moT01 merged commit 992fc8f into freeCodeCamp:master Aug 11, 2019
@joelzehring
Copy link
Contributor Author

joelzehring commented Aug 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants