-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make challenge links on profile page work #36701
fix: make challenge links on profile page work #36701
Conversation
I'll take a proper look at this soon, but my first impressions are that this is a nice solution. The extra work the server has to do is pretty small. I am still wondering if we can get away with not using the server at all. Nonetheless, if we are using it, this looks like the way to go. |
hey @raisedadead - I noticed that the certifications are part of the table on the profile, is this deliberate? |
We can update the styles. It was sort of a mess. Feel free to take a dig at it. |
@raisedadead The issue is that the TimeLine's cert links are currently 404s, so we were wondering if they should be filtered out or made to point at the certifications. Also, @RandellDawson noticed that the certifications appear in the TimeLine even if they aren't public. Presumably that's a bug! |
🤦♂ I need more coffee. Yes, this looks like a bug. |
it seems like we are moving in the direction of completely removing these links and making the the profile more resume like. I wonder if we should sunset this list now if fixing it is too time consuming. @raisedadead thoughts? |
I think this should be fixed now. We have not planned or designed anything about the "resume" like settings page. It could presumably take weeks. From my point of view this is a blocker issue right now from releasing master. I would defer to @QuincyLarson though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of nitpicks, but otherwise this looks good.
c4bf454
to
f03147f
Compare
Thanks for all the reviews lately everyone! 🎉 @raisedadead @ahmadabdolsaheb @RandellDawson @ojeytonwilliams @thecodingaviator @Manish-Giri @jonathan-grah 🎉 |
Update index.md
)master
branch of freeCodeCamp.Closes #36085