feat: SSR MathJax and Stripe on routes using them #37388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ojeytonwilliams
added
the
platform: learn
6 tasks
raisedadead
reviewed
Oct 18, 2019
client/src/head/index.js
Outdated
| @@ -1,8 +1,7 @@ | |||
| import meta from './meta'; | |||
| import mathjax from './mathjax'; | |||
| import scripts from './scripts'; | |||
There was a problem hiding this comment.
What is this file? Can we consolidate things here?
There was a problem hiding this comment.
scripts is empty now - it used to contain gtag. I think all the scripts are (as of this PR) in gatsby-ssr.
If that's a good place for them, we can just get rid of scripts entirely.
There was a problem hiding this comment.
Yes, please. And thanks for confirming.
raisedadead
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update index.md)masterbranch of freeCodeCamp.Attaches scripts to the body if they're needed. Stripe for
/donateand challenges and MathJax for the rosetta code challenges. This should be faster than waiting forcomponentDidMountbefore starting.Related to #37360