fix(curriculum): Improve verbiage and add examples to the map, filter, and reduce challenges #37709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
RandellDawson
changed the title
RandellDawson
added
language: English
scope: curriculum
RandellDawson
force-pushed
the
fix/add-examples-to-map-filter-reduce-challenges
branch
from
2178f41
to
f3a8cd8
Compare
RandellDawson
force-pushed
the
fix/add-examples-to-map-filter-reduce-challenges
branch
from
f3a8cd8
to
608da40
Compare
|
@raisedadead Why does Gitpod still show Pending status? When I click on Details link, it opens up Gitpod and creates the build and eventually shows everything working as it should. |
ojeytonwilliams
requested changes
Nov 11, 2019
There was a problem hiding this comment.
@RandellDawson since you wanted the verbiage shrinking I ended up being quite aggressive with the cuts/re-wording. Let me know if I went too far.
...ctures/functional-programming/use-the-filter-method-to-extract-data-from-an-array.english.md
Outdated
Show resolved
Hide resolved
...ctures/functional-programming/use-the-filter-method-to-extract-data-from-an-array.english.md
Outdated
Show resolved
Hide resolved
...ctures/functional-programming/use-the-filter-method-to-extract-data-from-an-array.english.md
Outdated
Show resolved
Hide resolved
...tructures/functional-programming/use-the-map-method-to-extract-data-from-an-array.english.md
Outdated
Show resolved
Hide resolved
...tructures/functional-programming/use-the-map-method-to-extract-data-from-an-array.english.md
Outdated
Show resolved
Hide resolved
...-and-data-structures/functional-programming/use-the-reduce-method-to-analyze-data.english.md
Outdated
Show resolved
Hide resolved
...-and-data-structures/functional-programming/use-the-reduce-method-to-analyze-data.english.md
Outdated
Show resolved
Hide resolved
...-and-data-structures/functional-programming/use-the-reduce-method-to-analyze-data.english.md
Outdated
Show resolved
Hide resolved
...-and-data-structures/functional-programming/use-the-reduce-method-to-analyze-data.english.md
Outdated
Show resolved
Hide resolved
...-and-data-structures/functional-programming/use-the-reduce-method-to-analyze-data.english.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Maybe it's just a glitch or something. 🤷♂ |
thecodingaviator
suggested changes
Nov 11, 2019
...-and-data-structures/functional-programming/use-the-reduce-method-to-analyze-data.english.md
Outdated
Show resolved
Hide resolved
...-and-data-structures/functional-programming/use-the-reduce-method-to-analyze-data.english.md
Outdated
Show resolved
Hide resolved
Manish-Giri
reviewed
Nov 12, 2019
...tructures/functional-programming/use-the-map-method-to-extract-data-from-an-array.english.md
Outdated
Show resolved
Hide resolved
Manish-Giri
reviewed
Nov 12, 2019
...tructures/functional-programming/use-the-map-method-to-extract-data-from-an-array.english.md
Show resolved
Hide resolved
Manish-Giri
reviewed
Nov 12, 2019
...ctures/functional-programming/use-the-filter-method-to-extract-data-from-an-array.english.md
Outdated
Show resolved
Hide resolved
Manish-Giri
reviewed
Nov 12, 2019
...ctures/functional-programming/use-the-filter-method-to-extract-data-from-an-array.english.md
Show resolved
Hide resolved
Manish-Giri
reviewed
Nov 12, 2019
...-and-data-structures/functional-programming/use-the-reduce-method-to-analyze-data.english.md
Outdated
Show resolved
Hide resolved
Manish-Giri
reviewed
Nov 12, 2019
...-and-data-structures/functional-programming/use-the-reduce-method-to-analyze-data.english.md
Outdated
Show resolved
Hide resolved
Manish-Giri
suggested changes
Nov 12, 2019
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
moT01
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
I'm fine with these changes. I think it's a big improvement. Looks good @RandellDawson 🎉
|
@moT01 I am still working on add @Manish-Giri's suggested changes. I will try to do that today and then request one last look from you all. |
|
@Manish-Giri and @thecodingaviator Can you please take one last review to see if this is ready to merge? Thanks. |
Manish-Giri
approved these changes
Nov 27, 2019
thecodingaviator
approved these changes
Nov 27, 2019
|
Thank you for your contribution to the page! 👍 |
RandellDawson
deleted the
fix/add-examples-to-map-filter-reduce-challenges
branch
abbathaw
pushed a commit
to abbathaw/freeCodeCamp
that referenced
this pull request
Jul 24, 2020
…, and reduce challenges (freeCodeCamp#37709) * fix: improve verbiage and add examples to challenges * fix: condensed map method wording Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix: remove leading space Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix: improved verbiage Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix: shortened reduce challenge verbiage Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix: shorten verbiage related to reduce 2nd parameter Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix: added comma Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix: shortened filter verbiage Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix; added comma Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix: improved verbiage of map method Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix: shortened reduce verbiage Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix: correct map method verbiage Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix: added word array Co-Authored-By: Manish Giri <manish.giri.me@gmail.com> * fix: added missing comma Co-Authored-By: Manish Giri <manish.giri.me@gmail.com> * fix: changed u to sumOfAges Co-Authored-By: Manish Giri <manish.giri.me@gmail.com> * fix: created one sentence out of many Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com> * fix: changed to on each iteration Co-Authored-By: Manish Giri <manish.giri.me@gmail.com> * fix: fixed verbiage in filter and map challenges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update index.md)masterbranch of freeCodeCamp.Closes #37704
This PR attempts to explain in detail how each of the methods introduced in the following challenges work and includes examples of how to use them. The current versions of these challenges almost assume the user has already been taught how to use them, which is why the forum gets a lot of questions for these challenges.
Use the map Method to Extract Data from an Array
Use the filter Method to Extract Data from an Array
Use the reduce Method to Analyze Data
I also formatted the challenge seed code to use two space indentation, to reduce the line width of the code and make it more readable.