fix: remove donation prevention

[ahmaxed]

• I have read freeCodeCamp's contribution guidelines.
• My pull request has a descriptive title (not a vague title like Update index.md)
• My pull request targets the master branch of freeCodeCamp.
• None of my changes are plagiarized from another source without proper attribution.
• All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
• My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

[gitpod-io]

[ahmaxed]

@ojeytonwilliams turns out we don't need to prevent donation since donation prompts happen less often on the previous donation modal logic.

could you take a look please?

[ojeytonwilliams]

Removing preventDonationRequests means that once you trigger the DonationModal you see it every time you mount a page inside /learn. To fix this, how about using preventDonationRequests, but only in showDonateModalSaga and have it flip canRequestDonation back to false?

That way the donation message should always be visible on certs and the donation modal should only pop up after you complete a block (but if you complete multiple blocks in a session, you will see multiple modals).

[ahmaxed]

@ojeytonwilliams you are right. although I am not sure I follow logic for using preventDonationRequests for setting canRequestDonation back go false. in that case what would flip canRequestDonation to true?

How about flipping tryToShowDonationModal back to false after the donation pop up?

[ojeytonwilliams]

in that case what would flip canRequestDonation to true?

That will happen each time you finish a block, same as before. The idea (in my last commit) is to have block completion flip canRequestDonation to true and then the modal's appearance (i.e. the saga) flips it back to false. That way the modal appears, once, each time you finish a block.

[ojeytonwilliams]

LGTM 👍