Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed position challenge #37945

Merged
merged 1 commit into from
Jan 3, 2020
Merged

fix: fixed position challenge #37945

merged 1 commit into from
Jan 3, 2020

Conversation

moT01
Copy link
Member

@moT01 moT01 commented Dec 16, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #36836

@gitpod-io
Copy link

gitpod-io bot commented Dec 16, 2019

@camperbot camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Dec 16, 2019
ojeytonwilliams
ojeytonwilliams approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cmccormack
cmccormack approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@cmccormack cmccormack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍. Thank you for your contribution!

@cmccormack cmccormack merged commit 0adfc79 into freeCodeCamp:master Jan 3, 2020
@moT01 moT01 deleted the fix/fixed-positioning-challenge branch January 5, 2020 17:45
abbathaw pushed a commit to abbathaw/freeCodeCamp that referenced this pull request Jul 24, 2020
@moT01 @abbathaw
fix: fixed position challenge (freeCodeCamp#37945)
632b5c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmccormack cmccormack cmccormack approved these changes

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Applied Visual Design: Lock an Element to the Browser Window with Fixed Positioning
4 participants
@moT01 @cmccormack @ojeytonwilliams @camperbot