Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): use assert.deepEqual to compare arrays instead of JSON.stringify for Use the map Method to Extra Data from an Array challenge #37959

Merged
merged 1 commit into from Dec 31, 2019
Merged

fix(curriculum): use assert.deepEqual to compare arrays instead of JSON.stringify for Use the map Method to Extra Data from an Array challenge #37959

merged 1 commit into from Dec 31, 2019

Conversation

RandellDawson
Copy link
Member

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
  • My changes do not use shortened URLs or affiliate links.

Closes #37958

Fixes bug noticed by user for the Use the map Method to Extract Data from an Array challenge. This PR changes the one test to use assert.deepEqual to compare the two arrays instead of JSON.stringifying the two arrays.

@gitpod-io
Copy link

gitpod-io bot commented Dec 18, 2019

@RandellDawson RandellDawson added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Dec 18, 2019
@raisedadead raisedadead merged commit 1f98af5 into freeCodeCamp:master Dec 31, 2019
@RandellDawson RandellDawson deleted the fix/use-assert-deepequal-to-compare-objects-in-use-the-map-method-to-extract-data-from-an-array-challenge branch January 4, 2020 16:24
abbathaw pushed a commit to abbathaw/freeCodeCamp that referenced this pull request Jul 24, 2020
@RandellDawson @abbathaw
fix: used assert.deepEqual to compare arrays (freeCodeCamp#37959)
61e148a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nothing
2 participants
@RandellDawson @raisedadead