Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct code does not pass in 'Nest an Anchor' waypoint #3805

Closed
riteshshrv opened this issue Oct 19, 2015 · 4 comments
Closed

Correct code does not pass in 'Nest an Anchor' waypoint #3805

riteshshrv opened this issue Oct 19, 2015 · 4 comments
Assignees

Comments

@riteshshrv
Copy link

screenshot from 2015-10-19 22 00 11
Challenge Waypoint: Nest an Anchor Element within a Paragraph has an issue.
User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.101 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

My code:

<link href="http://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">
<style>
  .red-text {
    color: red;
  }

  h2 {
    font-family: Lobster, Monospace;
  }

  p {
    font-size: 16px;
    font-family: Monospace;
  }

  .thick-green-border {
    border-color: green;
    border-width: 10px;
    border-style: solid;
    border-radius: 50%;
  }

  .smaller-image {
    width: 100px;
  }
</style>

<h2 class="red-text">CatPhotoApp</h2>

<a href="http://www.freecatphotoapp.com">cat photos</a>

<img class="smaller-image thick-green-border" src="https://bit.ly/fcc-relaxing-cat">

<p class="red-text">Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.</p>
<p class="red-text">Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.</p>
<p>View more <a href="http://www.freecatphotoapp.com">cat photos</a></p>
@ltegman
Copy link
Member

ltegman commented Oct 19, 2015

This challenge is asking to you wrap the existing <a> tag that is right below the <h2>, not create a new one at the bottom. The test expects to find your <p> up there with the original <a>, so adding it down at the bottom causes the test to fail.

However, this is the third time in a week or so that I've seen this same issue reported, so I propose adding some clarifying language to the waypoint that lets the user know they should not be moving existing <a> tag, only wrapping it.

@riteshshrv
Copy link
Author

It worked. Indeed the language should be more clarifying.

@dcsan dcsan added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Oct 20, 2015
ltegman added a commit to ltegman/FreeCodeCamp that referenced this issue Oct 20, 2015
Added comments to delineate which areas of the code should be modified since we were seeing a lot of confusion on the tests not passing when the `p` tag was at the bottom of the page.
Closes freeCodeCamp#3805
@anrddh anrddh removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Oct 20, 2015
@idanceicode
Copy link

Great, just reading your your response. Unsure if you have added clarifying language yet but I have run into the same isue...as of two days ago, 10/21...

@ltegman
Copy link
Member

ltegman commented Oct 24, 2015

The change has been pulled into the staging branch but hasn't been pushed into the production code yet. It shouldn't be too long before it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants