Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): use example in Modifying an Object Within a Nested Object challenge #38468

Merged
merged 5 commits into from
May 15, 2020
Merged

fix(curriculum): use example in Modifying an Object Within a Nested Object challenge #38468

merged 5 commits into from
May 15, 2020

Conversation

AshNaz87
Copy link
Contributor

@AshNaz87 AshNaz87 commented Mar 29, 2020 •
edited by RandellDawson

…se to explain how to do so

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #38463

@gitpod-io
Copy link

gitpod-io bot commented Mar 29, 2020 •
edited

@AshNaz87
Copy link
Contributor Author

Screenshot 2020-03-29 at 21 59 29

RandellDawson
RandellDawson previously requested changes Mar 29, 2020
View reviewed changes
Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestions for making the wording a bit more concise.

...nd-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md Outdated Show resolved Hide resolved
...nd-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md Outdated Show resolved Hide resolved
@RandellDawson RandellDawson changed the title fix: use example in modifying an object within a nested object exerci… fix(curriculum): use example in Modifying an Object Within a Nested Object challenge Mar 29, 2020
AshNaz87 and others added 2 commits March 30, 2020 01:03
@AshNaz87 @RandellDawson
Update curriculum/challenges/english/02-javascript-algorithms-and-dat…
b8589ed 
…a-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
@AshNaz87 @RandellDawson
Update curriculum/challenges/english/02-javascript-algorithms-and-dat…
eb6dcbd 
…a-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
@camperbot camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Apr 1, 2020
@AshNaz87
Copy link
Contributor Author

AshNaz87 commented Apr 3, 2020

@RandellDawson Is this good to go?

@danielramosbh74 danielramosbh74 mentioned this pull request Apr 6, 2020
Closed
moT01
moT01 approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @AshNaz87 🎉

ShaunSHamilton
ShaunSHamilton requested changes May 13, 2020
View reviewed changes
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicking.

...nd-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md Outdated Show resolved Hide resolved
...nd-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md Outdated Show resolved Hide resolved
AshNaz87 and others added 2 commits May 13, 2020 13:54
@AshNaz87 @ShaunSHamilton
Update curriculum/challenges/english/02-javascript-algorithms-and-dat…
2f6a7e3 
…a-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
@AshNaz87 @ShaunSHamilton
Update curriculum/challenges/english/02-javascript-algorithms-and-dat…
f554161 
…a-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
ShaunSHamilton
ShaunSHamilton approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moT01
Copy link
Member

moT01 commented May 13, 2020

Lets try again...

@moT01 moT01 closed this May 13, 2020
@moT01 moT01 reopened this May 13, 2020
@gitpod-io
Copy link

gitpod-io bot commented May 13, 2020

@moT01 moT01 dismissed RandellDawson’s stale review May 15, 2020 21:40

Changes have been applied

moT01
moT01 approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @AshNaz87 🎉 Thanks for contributing to freeCodeCamp 🎉

@moT01 moT01 merged commit e10a046 into freeCodeCamp:master May 15, 2020
abbathaw pushed a commit to abbathaw/freeCodeCamp that referenced this pull request Jul 24, 2020
@AshNaz87 @RandellDawson
@ShaunSHamilton @abbathaw
fix(curriculum): use example in Modifying an Object Within a Nested O…
9a9d397 
…bject challenge (freeCodeCamp#38468)

* fix: use example in modifying an object within a nested object exercise to explain how to do so

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@ShaunSHamilton ShaunSHamilton ShaunSHamilton approved these changes

@RandellDawson RandellDawson RandellDawson left review comments

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove redundant challenge (or fix it)
5 participants
@AshNaz87 @moT01 @RandellDawson @ShaunSHamilton @camperbot