Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): update solution to match seed #38828

Merged
merged 1 commit into from
May 18, 2020

Conversation

vsasvipul0605
Copy link
Contributor

@vsasvipul0605 vsasvipul0605 commented May 15, 2020

…ish.md

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #38829

According to recent changes on site, the arrow function is not there. So, here's the updated solution for the updated challenge.

@gitpod-io
Copy link

gitpod-io bot commented May 15, 2020

@camperbot camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels May 15, 2020
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@erictleung erictleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ojeytonwilliams ojeytonwilliams changed the title solution-update for pass-arguments-to-avoid-external-dependence-in-a-function.engl… fix(curriculum): update solution to match seed May 18, 2020
@ojeytonwilliams ojeytonwilliams merged commit 7e2b159 into freeCodeCamp:master May 18, 2020
@ojeytonwilliams
Copy link
Contributor

@vsasvipul0605 Congrats on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝

@ojeytonwilliams
Copy link
Contributor

By the way, @vsasvipul0605, if you want to keep using your fork you'll need to get a new version of master from upstream, since it will be out of sync now this PR has been merged.

@vsasvipul0605
Copy link
Contributor Author

@ojeytonwilliams okay and thanks for merging the pull request. This will motivate me to contribute more and more.

@vsasvipul0605
Copy link
Contributor Author

and can anyone please tell me how can I become contributor in freecodecamp?
after how many PR's or any such criteria?

@ojeytonwilliams
Copy link
Contributor

Well, you're already a contributor now that this PR has been merged. As for anything beyond that, it's not really something I can talk about with any authority. Personally I just contributed PRs and helped out a bit in Gitter, but I don't think there's a formal process.

abbathaw pushed a commit to abbathaw/freeCodeCamp that referenced this pull request Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

curriculum-challenges-solution-update
4 participants