Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: eslint security plugin #38844

Closed
wants to merge 4 commits into from
Closed

Add: eslint security plugin #38844

wants to merge 4 commits into from

Conversation

MrSlimCoder
Copy link
Contributor

@MrSlimCoder MrSlimCoder commented May 18, 2020 •
edited

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

@MrSlimCoder MrSlimCoder requested a review from a team May 18, 2020 20:41
@gitpod-io
Copy link

gitpod-io bot commented May 18, 2020 •
edited

@MrSlimCoder
Copy link
Contributor Author

MrSlimCoder commented May 18, 2020 •
edited

Hey! i added eslint security and found 300+ problems in the codebase i think we should fix it is related to security.

@MrSlimCoder MrSlimCoder mentioned this pull request May 18, 2020
Closed
@MrSlimCoder
Copy link
Contributor Author

I want to fix all warnings and bugs from codebase so should I continue to work on this PR?

@MrSlimCoder
Copy link
Contributor Author

Guy's added a fix commit which fix generic object injection sink warning.

ShaunSHamilton
ShaunSHamilton reviewed Jun 4, 2020
View reviewed changes
tools/translation/translate-challenges.js Outdated
@@ -123,7 +123,7 @@ function processFile(
let transIndex = 0;
testsArray.forEach((test, index) => {
if (test.includes('- text')) {
testsArray[index] = ' - text: ' + translation[parseInt(transIndex)];
testsArray[parseIn(index)] = ' - text: ' + translation[parseInt(transIndex)];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch out for typos 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outdated comment i have fixed this typo .

@github-actions github-actions bot added status: merge conflict To be applied to PR's that have a merge conflict and need updating and removed status: merge conflict To be applied to PR's that have a merge conflict and need updating labels Jul 27, 2020
@raisedadead raisedadead added the other: decayed Stale issues that need follow up from commentators. Were closed for inactivity label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunSHamilton ShaunSHamilton ShaunSHamilton left review comments

Assignees
No one assigned
Labels
other: decayed Stale issues that need follow up from commentators. Were closed for inactivity status: merge conflict To be applied to PR's that have a merge conflict and need updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrSlimCoder @ShaunSHamilton @raisedadead @vivekanand999