fix: backend projects not submitting #38900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ojeytonwilliams
approved these changes
May 26, 2020
There was a problem hiding this comment.
I finished the clean up (there was still some backendFormValue code), but it all seems to be working nicely.
All the form submission goes through SolutionForm so there's no need to track backend challenge, backend project or frontend project form values separately any more. At least that's my understanding.
raisedadead
added
platform: learn
raisedadead
pushed a commit
that referenced
this pull request
May 26, 2020
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
raisedadead
pushed a commit
that referenced
this pull request
May 27, 2020
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
raisedadead
pushed a commit
that referenced
this pull request
May 27, 2020
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
abbathaw
pushed a commit
to abbathaw/freeCodeCamp
that referenced
this pull request
Jul 24, 2020
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix number 3 in this comment
Some issues with the form values not being updated correctly. Making this a draft for now, some of the things I deleted may be needed yet. Want to make sure.
The change that made things work is on like 181 of
show.jsUpdate index.md)masterbranch of freeCodeCamp.Closes #XXXXX