Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a brief note regarding function hoisting #38975

Closed
wants to merge 1 commit into from

Conversation

RichardJamesC
Copy link

Checklist:

  • [ x] I have read freeCodeCamp's contribution guidelines.
  • [ x] My pull request has a descriptive title (not a vague title like Update index.md)
  • [ x] My pull request targets the master branch of freeCodeCamp.
  • [ x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

@gitpod-io
Copy link

gitpod-io bot commented May 31, 2020

@camperbot camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Jun 1, 2020
Copy link

@tinktink1 tinktink1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really liked your idea about adding a brief note and I am sure it will help clear up some confusion. I have read your changes and as far as I can tell the grammar seems to be good. Good work!

@naomi-lgbt
Copy link
Member

While this is good information, the concern is that we do not want the challenge instructions to become "walls of text". As this information does not directly apply to the challenge itself, can you walk me through why you feel it is essential to add this to the instructions? 🙂

@RandellDawson
Copy link
Member

Since the extra information does not help in solving the problem presented in the instructions, it is just extra information. I am going to close this PR for now.

@RichardJamesC If you can reply back with how this addition allows the user to pass the challenge, then we could consider reopening the PR.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants