JSON/API Lesson Cleanup #4022
Merged
JSON/API Lesson Cleanup #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcsan
added
the
status: waiting review
ltegman
force-pushed
the
fix/json-api-lesson-cleanup
branch
from
bce177e
to
a7b7201
Compare
ltegman
force-pushed
the
fix/json-api-lesson-cleanup
branch
from
a7b7201
to
d1de10e
Compare
ltegman
force-pushed
the
fix/json-api-lesson-cleanup
branch
from
d1de10e
to
8ecde25
Compare
|
Resolved 😄 |
| "assert(editor.match(/\\s*?\\}\\s*?\\)\\s*?\\;/gi) && editor.match(/\\,\\s*?function\\s*?\\(\\s*?\\w*?\\s*?\\)\\s*?\\{/gi) && editor.match(/\\s*?\\}\\s*?\\)\\s*?\\;/gi).length === editor.match(/\\s*?function\\s*?\\(\\s*?\\w*?\\s*?\\)\\s*?\\{/gi).length, 'Each callback function should have a closing set of brackets and parenthesis.')", | ||
| "assert(editor.match(/\\$\\s*?\\.\\s*?getJSON\\s*?\\(\\s*?\"\\\/json\\\/cats\\.json\\?callback\\=\"\\s*?\\,\\s*?function\\s*?\\(\\s*?json\\s*?\\)\\s*?\\{/gi), 'You should be making use of the getJSON method given in the description to load data from the json file.')", | ||
| "assert(editor.match(/\\$\\s*?\\(\\s*?\\\"\\.message\\\"\\s*?\\)\\s*?\\.\\s*?html\\s*?\\(\\s*?JSON\\s*?\\.\\s*?stringify\\s*?\\(\\s*?json\\s*?\\)\\s*?\\)/gi), 'Don\\'t forget to make the <code>.html</code> change the contents of the message box so that it contains the result of the getJSON.')" | ||
| "assert(editor.match(/\\$\\s*?\\.\\s*?getJSON\\s*?\\(\\s*?(\\\"|\\')\\\/json\\\/cats\\.json\"\\s*?\\,\\s*?function\\s*?\\(\\s*?json\\s*?\\)\\s*?\\{/gi), 'You should be making use of the getJSON method given in the description to load data from the json file.')", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
+ Fixes Convert JSON to HTML lesson (Closes freeCodeCamp#4016) + Add Formatting to Geolocation lesson output (Closes freeCodeCamp#4010) + Fixes Render Images lesson + Removes unnecessary `?callback=` from JSON challenges. (Closes freeCodeCamp#3972) + Lots of other formatting and consistancy changes. + Also closes freeCodeCamp#3962 and closes freeCodeCamp#3969
ltegman
force-pushed
the
fix/json-api-lesson-cleanup
branch
from
8ecde25
to
086b0bb
Compare
|
Leftover regex |
BerkeleyTrue
removed
the
status: waiting review
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?callback=from JSON challenges. (Closes remove?callback=from Get JSON challenge #3972)