Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added Change this line comment in Redux Challenge #40497

Merged
merged 1 commit into from
Jan 21, 2021
Merged

fix: Added Change this line comment in Redux Challenge #40497

merged 1 commit into from
Jan 21, 2021

Conversation

NirajNair
Copy link
Contributor

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #40489

@gitpod-io
Copy link

gitpod-io bot commented Dec 20, 2020

@NirajNair NirajNair changed the title Added Change this line comment Added Change this line comment in Redux Challenge Dec 20, 2020
@NirajNair NirajNair changed the title Added Change this line comment in Redux Challenge fix: Added Change this line comment in Redux Challenge Dec 20, 2020
ShaunSHamilton
ShaunSHamilton approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍

Congratulations on your first PR to this repo! We look forward to your future contribution

@ShaunSHamilton ShaunSHamilton added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. labels Dec 20, 2020
naomi-lgbt
naomi-lgbt approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~! 🥳

Congratulations on your first pull request to this project! We look forward to future contributions!

Please note that we are in a code freeze at the moment, so merging this will wait until that is lifted. 🙂

@NirajNair
Copy link
Contributor Author

This LGTM 👍

Congratulations on your first PR to this repo! We look forward to your future contribution

Thank you so much!

@NirajNair
Copy link
Contributor Author

LGTM~! 🥳

Congratulations on your first pull request to this project! We look forward to future contributions!

Please note that we are in a code freeze at the moment, so merging this will wait until that is lifted. 🙂

Thank you so much!

@RohiniMallem
Copy link

RohiniMallem commented Dec 20, 2020 via email

@RandellDawson RandellDawson removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Jan 21, 2021
@RandellDawson RandellDawson merged commit a8230fd into freeCodeCamp:master Jan 21, 2021
@RandellDawson
Copy link
Member

Congrats @NirajNair on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunSHamilton ShaunSHamilton ShaunSHamilton approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the change code below/above line instructions for Redux challenge:Use const for Action Types
5 participants
@NirajNair @RohiniMallem @RandellDawson @ShaunSHamilton @naomi-lgbt