Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(learn): removing test case for regex challenge #40581

Merged
merged 1 commit into from
Jan 21, 2021
Merged

fix(learn): removing test case for regex challenge #40581

merged 1 commit into from
Jan 21, 2021

Conversation

alsoto25
Copy link
Contributor

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #40376

  • Removed test case that wasn't accepting valid regex for challenge Regular Expressions: Reuse Patterns Using Capture Groups

@gitpod-io
Copy link

gitpod-io bot commented Dec 29, 2020

@raisedadead raisedadead added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Jan 13, 2021
@naomi-lgbt naomi-lgbt added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Jan 13, 2021
RandellDawson
RandellDawson approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Still works fine with various regex solutions attempted.

@RandellDawson RandellDawson removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Jan 21, 2021
naomi-lgbt
naomi-lgbt approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~! 🥳 Grabbed a few solutions from the forums to test against, and this seems to work as intended.

Thank you for your pull request! We look forward to additional contributions!

@naomi-lgbt naomi-lgbt merged commit ef39409 into freeCodeCamp:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandellDawson RandellDawson RandellDawson approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Challenge "Regular Expressions: Reuse Patterns Using Capture Groups" not accepting a valid regex
4 participants
@alsoto25 @RandellDawson @naomi-lgbt @raisedadead