Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated JSON string in snippet for Python Web Services #40742

Conversation

Dusch4593
Copy link
Contributor

@Dusch4593 Dusch4593 commented Jan 19, 2021

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

When I ran the code on my editor as-is, I received a weird error. I realized that the properties and value strings inside the JSON string are supposed to be double-quoted, not single-quoted. I believe it's a standard followed by JSON. When I made the change and ran on my editor, the expected output was printed and there were no errors.

@gitpod-io
Copy link

gitpod-io bot commented Jan 19, 2021

Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dusch4593 this LGTM 👍

Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~! 🥳

Thank you for your pull request! We look forward to additional contributions!

Please note that we are currently in a code freeze and are not merging PRs to curriculum challenges at the moment. 🙂

@RandellDawson RandellDawson added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jan 21, 2021
@RandellDawson RandellDawson merged commit 570d9ad into freeCodeCamp:master Jan 21, 2021
@RandellDawson
Copy link
Member

Congrats @Dusch4593 on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants