Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): remove external prop on 'donate' link #41023

Merged
merged 2 commits into from Feb 9, 2021

Conversation

kelvinsanchez15
Copy link
Contributor

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #41016

@kelvinsanchez15 kelvinsanchez15 requested a review from a team February 9, 2021 22:18
@gitpod-io
Copy link

gitpod-io bot commented Feb 9, 2021

@naomi-lgbt
Copy link
Member

Testing locally, I can confirm this resolves the issue of /espanol being removed from the donation redirect.

@kelvinsanchez15 I'll generate a suggestion to resolve the linting error momentarily.

Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion tool is not cooperating.

Replace:

          <Link
            className='nav-link'
            key='donate'
            sameTab={false}
            to='/donate'
          >
            {t('buttons.donate')}
          </Link>

With:

          <Link className='nav-link' key='donate' sameTab={false} to='/donate'>
            {t('buttons.donate')}
          </Link>

@kelvinsanchez15
Copy link
Contributor Author

Thanks @nhcarrigan as soon as I have some time I will configure a proper fCC local instance.

Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@raisedadead raisedadead changed the title Remove Link external prop to fix 'donate' link redirect issue in spanish version fix(client): remove external prop on 'donate' link Feb 9, 2021
@raisedadead raisedadead merged commit 0a72787 into freeCodeCamp:main Feb 9, 2021
@kelvinsanchez15 kelvinsanchez15 deleted the patch-2 branch February 18, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking the 'donate' link in the navbar menu does not redirect to the spanish version of the page
3 participants