fix: remove algolia indices and urls from translations

[scissorsneedfoodtoo]

Checklist:

• I have read freeCodeCamp's contribution guidelines.
• My pull request has a descriptive title (not a vague title like Update index.md)
• My pull request targets the main branch of freeCodeCamp.
• All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #41029

This PR moves the Algolia index names and News search page URLs out of the translation.json files to prevent accidental changes on CrowdIn.

It also adds some basic tests for the search bar.

[gitpod-io]

[raisedadead]

LGTM.

@RandellDawson This would be a good test of what happens we delete stuff on a translated file both the source and translation.

[RandellDawson]

@raisedadead @nhcarrigan and I have a plan.

1. Merge any PR with changes to the English source (when they are ready)
2. Upload the English source via the normal Crowdin upload workflow
3. I will manually add all the translations that were made two the intros.json and translations.json (Nick will approve)
4. Run the download for these files (after a small tweak to the config to allow both files to be downloaded but only approved strings come down).

This is the easiest way to bring us back into sync. Hopefully, we will not be making any further changes to the non-English versions of these files outside of Crowdin in the future.

[scissorsneedfoodtoo]

@RandellDawson, looking at the translations.json file, it seems like there are about 12 links there. I think 11 of them are related to the footer, and one is for an error message.

Would it be better to extract those footer links from the translations.json file and merge them with the ones in trending.json? We'd probably have to rename trending.json to something like footer-links.json, too. That's assuming we'll handle all the footer links and text localization in house.

I'm thinking this might be the way to go because we've had some issues with text overflow on News, and need to make changes before updating the theme.

If we'll handle those on Crowdin as well, is it possible to hide those links so they're not accidentally changed?

[RandellDawson]

If we'll handle those on Crowdin as well, is it possible to hide those links so they're not accidentally changed?

@scissorsneedfoodtoo We can hide any string in the JSON files manually or create an action to hide specific keys' values by key name (i.e. footer.links.about-url). I count 10 urls as stand-along values in the translations.json file. 9 start with footer.links and one is donate.other-ways-url.

I would leave them in translations.json. We could hide anything that had a key ending in -url.

[scissorsneedfoodtoo]

@RandellDawson, awesome, that sounds like a plan. Looking over the file again we shouldn't need to remove any other keys, at least as far as I can tell.

[ojeytonwilliams]

Let's not mix translatable and untranslatable content in one file if we can avoid it. We already have files like trending.json for content that differs between the languages, but does not want translating. I think we should do the same here.