-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client) fixed icon height in containers #41086
Conversation
@ahmadabdolsaheb do you mind giving us an approval for merge. Thanks. |
I think the thumbs-up is the approval. |
Nope, it's not. It just means he has acknowledged my request. We have a certain internal policy about the QA. We request your patience while we get around to it, cheers. |
I'm sorry I didn't know that I will wait on Ahmads approval. |
Hey @Sembauke, there's nothing to apologise for - it's great that you're helping out with the UI. The approval in question here is just an approving review. So, assuming Ahmad's happy, he'll do that and we can merge this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience. Other than the following nitpick, the PR looks good.
Can I get a review from @ahmadabdolsaheb |
Thanks @Sembauke, the /learn page looks nicer now. |
Thanks |
Checklist:
Update index.md
)main
branch of freeCodeCamp.Closes #XXXXX
fix for issue #41083 this is a fix for the containers not having a fixed height and icon sizes are standardized