Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client) fixed icon height in containers #41086

Merged
merged 2 commits into from
Feb 24, 2021
Merged

fix(client) fixed icon height in containers #41086

merged 2 commits into from
Feb 24, 2021

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Feb 12, 2021

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

fix for issue #41083 this is a fix for the containers not having a fixed height and icon sizes are standardized

@Sembauke Sembauke requested a review from a team February 12, 2021 17:42
@gitpod-io
Copy link

gitpod-io bot commented Feb 12, 2021

@raisedadead
Copy link
Member

@ahmadabdolsaheb do you mind giving us an approval for merge. Thanks.

@Sembauke
Copy link
Member Author

@ahmadabdolsaheb do you mind giving us an approval for merge. Thanks.

I think the thumbs-up is the approval.

@raisedadead
Copy link
Member

I think the thumbs-up is the approval.

Nope, it's not. It just means he has acknowledged my request.

We have a certain internal policy about the QA. We request your patience while we get around to it, cheers.

@Sembauke
Copy link
Member Author

I think the thumbs-up is the approval.

Nope, it's not. It just means he has acknowledged my request.

We have a certain internal policy about the QA. We request your patience while we get around to it, cheers.

I'm sorry I didn't know that I will wait on Ahmads approval.

@ojeytonwilliams
Copy link
Contributor

Hey @Sembauke, there's nothing to apologise for - it's great that you're helping out with the UI.

The approval in question here is just an approving review. So, assuming Ahmad's happy, he'll do that and we can merge this in.

Copy link
Member

@ahmaxed ahmaxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience. Other than the following nitpick, the PR looks good.

client/src/components/landing/landing.css Outdated Show resolved Hide resolved
@raisedadead raisedadead added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Feb 18, 2021
@raisedadead raisedadead removed the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Feb 20, 2021
@Sembauke
Copy link
Member Author

Can I get a review from @ahmadabdolsaheb

@ojeytonwilliams ojeytonwilliams merged commit 5a3903f into freeCodeCamp:main Feb 24, 2021
@ojeytonwilliams
Copy link
Contributor

Thanks @Sembauke, the /learn page looks nicer now.

@Sembauke
Copy link
Member Author

Thanks @Sembauke, the /learn page looks nicer now.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants