-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): add common links to formValidators regex #41094
feat(client): add common links to formValidators regex #41094
Conversation
is submitting https://repl.it/join/ .... common? |
It has happened twice that I have seen. This PR can hold off, though, as there might be scope to add validation that the links submitted does not include the boilerplate URLs. Specifically, we discussed this on the fCC chat in Contributors - ensure Campers do not submit the CodePen boilerplate, thinking they have their code submitted and saved. |
Do you mean, you intend to expand the scope of the PR to add more invalid URL patterns? |
@raisedadead Yes. There was some discussion about it, but I will actually open an issue specifically about it, first - for clarity. I will set this to a work in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Nice work, Shaun. It occurs to me that we should translate these messages, but that's a job for another PR.
Checklist:
Update index.md
)main
branch of freeCodeCamp.This PR adds links like
https://repl.it/join/Sky020
to the editor validation. As well as freeCodeCamp related links:freeCodeCamp.rocks
linksNever ceases to amaze how many different links Campers will submit before the correct one.