Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add common links to formValidators regex #41094

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

ShaunSHamilton
Copy link
Member

@ShaunSHamilton ShaunSHamilton commented Feb 13, 2021

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

This PR adds links like https://repl.it/join/Sky020 to the editor validation. As well as freeCodeCamp related links:

  • CodePen links
  • GitHub boilerplate links
  • freeCodeCamp.rocks links

Never ceases to amaze how many different links Campers will submit before the correct one.

@ShaunSHamilton ShaunSHamilton added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Feb 13, 2021
@ShaunSHamilton ShaunSHamilton requested a review from a team February 13, 2021 17:19
@gitpod-io
Copy link

gitpod-io bot commented Feb 13, 2021

@ahmaxed
Copy link
Member

ahmaxed commented Feb 16, 2021

is submitting https://repl.it/join/ .... common?

@ShaunSHamilton
Copy link
Member Author

is submitting https://repl.it/join/ .... common?

It has happened twice that I have seen. This PR can hold off, though, as there might be scope to add validation that the links submitted does not include the boilerplate URLs.

Specifically, we discussed this on the fCC chat in Contributors - ensure Campers do not submit the CodePen boilerplate, thinking they have their code submitted and saved.

@raisedadead
Copy link
Member

This PR can hold off, though, as there might be scope to add validation that the links submitted does not include the boilerplate URLs.

Do you mean, you intend to expand the scope of the PR to add more invalid URL patterns?

@ShaunSHamilton
Copy link
Member Author

you intend to expand the scope of the PR to add more invalid URL patterns?

@raisedadead Yes. There was some discussion about it, but I will actually open an issue specifically about it, first - for clarity.

I will set this to a work in progress

@ShaunSHamilton ShaunSHamilton added the status: PR in works Work in Progress (WIP) Issues. label Feb 17, 2021
@ShaunSHamilton ShaunSHamilton marked this pull request as draft February 17, 2021 15:47
@ShaunSHamilton ShaunSHamilton changed the title feat(client): add repl join link to formValidators regex feat(client): add common links to formValidators regex Feb 18, 2021
@ShaunSHamilton ShaunSHamilton added status: need to test locally status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: PR in works Work in Progress (WIP) Issues. labels Feb 18, 2021
@ShaunSHamilton ShaunSHamilton marked this pull request as ready for review February 18, 2021 16:05
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Nice work, Shaun. It occurs to me that we should translate these messages, but that's a job for another PR.

@ojeytonwilliams ojeytonwilliams merged commit b2ec1a3 into freeCodeCamp:main Feb 19, 2021
@ShaunSHamilton ShaunSHamilton deleted the feat/add-repl-join branch February 19, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants