Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): move to lockfile v2, and run audit fix #41210

Merged
merged 8 commits into from
Feb 26, 2021

Conversation

raisedadead
Copy link
Member

No description provided.

@gitpod-io
Copy link

gitpod-io bot commented Feb 21, 2021

@ojeytonwilliams
Copy link
Contributor

There's some annoying warn Critical dependency: the request of a dependency is an expression webpack errors that I can't escape. One of the packages the client relies on is dynamically requiring something in a way webpack doesn't like, but we can't do anything about that besides not use that version of that package ... and the warning doesn't tell us where the problem comes from.

If all our tests pass, chances are it wasn't critical, but we can always put off using this until that goes away.

@ojeytonwilliams
Copy link
Contributor

Main objective achieved, though, it looks like we're safe with npm 7 lockfiles.

@raisedadead raisedadead marked this pull request as ready for review February 26, 2021 19:14
@raisedadead raisedadead requested a review from a team February 26, 2021 19:14
@naomi-lgbt
Copy link
Member

Running clean-and-develop with npm version 6.14.11 produces those warnings that Oliver was mentioning:

image

These messages persist when I use npm version 7.6.0. In both cases, everything seems to function as intended still.

@raisedadead raisedadead merged commit d87d8f3 into freeCodeCamp:main Feb 26, 2021
@raisedadead raisedadead deleted the fix/update-deps branch February 26, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants