Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enable chinese link #41227

Merged
merged 1 commit into from Feb 23, 2021

Conversation

naomi-lgbt
Copy link
Member

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

Enables the Chinese link in the translation menu. The files are not yet 100% translated, but the two that focus on our translation flow are. Having these available could potentially increase our translation contributions.

@naomi-lgbt naomi-lgbt added scope: docs Codebase and other documentation scope: i18n language translation/internationalization. Often combined with language type label labels Feb 22, 2021
@gitpod-io
Copy link

gitpod-io bot commented Feb 22, 2021

@raisedadead
Copy link
Member

I think we should add Portuguese which has hit 100% (translated, not-proofread) as well.

@naomi-lgbt
Copy link
Member Author

Sure - I'll need to modify the workflow to allow those files to be downloaded, migrate the English files into a Portuguese folder (to avoid 404s until translations are approved) and add the link.

Given the scope, should I do that in a separate PR so as to avoid blocking this one?

@raisedadead
Copy link
Member

Sounds good.

@raisedadead raisedadead merged commit 3dd33d8 into freeCodeCamp:main Feb 23, 2021
@naomi-lgbt naomi-lgbt deleted the docs/enable-chinese branch March 5, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs Codebase and other documentation scope: i18n language translation/internationalization. Often combined with language type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants