Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tool): Added more files to restrict from direct translations #41243

Merged
merged 3 commits into from Feb 24, 2021
Merged

fix(tool): Added more files to restrict from direct translations #41243

merged 3 commits into from Feb 24, 2021

Conversation

RandellDawson
Copy link
Member

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

This PR adds the non-English versions of intro.json and translations.json to the files restricted from PRs coming from forked repos.

@RandellDawson RandellDawson added scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Feb 24, 2021
@gitpod-io
Copy link

gitpod-io bot commented Feb 24, 2021 •
edited

@RandellDawson
Copy link
Member Author

Feel free to suggest alternate comment messages. I was not exactly sure what the message should say.

@RandellDawson @ojeytonwilliams
fix: added two files to restrict
0d2fdcb 
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
ojeytonwilliams
ojeytonwilliams previously approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@RandellDawson @raisedadead
fix: generalized text
ef4b060 
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
@raisedadead raisedadead merged commit c6d8996 into freeCodeCamp:main Feb 24, 2021
@RandellDawson RandellDawson deleted the fix/add-intro-and-translations-json-files-to-pr-restrictions branch February 25, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raisedadead raisedadead raisedadead approved these changes

@ojeytonwilliams ojeytonwilliams ojeytonwilliams left review comments

@naomi-lgbt naomi-lgbt Awaiting requested review from naomi-lgbt

Assignees
No one assigned
Labels
scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RandellDawson @raisedadead @ojeytonwilliams