Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(learn): rework Rosetta Code Count the Coins #41282

Merged
merged 2 commits into from
Mar 9, 2021
Merged

fix(learn): rework Rosetta Code Count the Coins #41282

merged 2 commits into from
Mar 9, 2021

Conversation

gikf
Copy link
Member

@gikf gikf commented Feb 27, 2021

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

@gitpod-io
Copy link

gitpod-io bot commented Feb 27, 2021 •
edited

@raisedadead raisedadead added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Mar 1, 2021
moT01
moT01 reviewed Mar 3, 2021
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably be fine merging this as-is, but the sentence in question sounded a little funny to me. What do you all think?

Note: I added this solution to the guide article (it was a stub previously).

curriculum/challenges/english/10-coding-interview-prep/rosetta-code/count-the-coins.md Outdated Show resolved Hide resolved
@gikf @moT01
fix: use better wording
0986f77 
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
naomi-lgbt
naomi-lgbt approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

For what it's worth, two of the three JavaScript solutions on the official Rosetta Code wiki take a cents (and denominations) input.

moT01
moT01 approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @gikf 🎉 Thanks for contributing to freeCodeCamp 🎉

@moT01 moT01 merged commit bd02249 into freeCodeCamp:main Mar 9, 2021
@gikf gikf deleted the fix/rework-rosetta-count-the-coins branch March 13, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandellDawson RandellDawson RandellDawson left review comments

@moT01 moT01 moT01 approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gikf @RandellDawson @moT01 @naomi-lgbt @raisedadead