Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: block-cta-wrapper breaking the layout in mobile view. #41299

Merged
merged 2 commits into from
Mar 4, 2021
Merged

fix: block-cta-wrapper breaking the layout in mobile view. #41299

merged 2 commits into from
Mar 4, 2021

Conversation

tegardp
Copy link
Contributor

@tegardp tegardp commented Feb 28, 2021

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #41266

@tegardp tegardp requested a review from a team February 28, 2021 06:47
@gitpod-io
Copy link

gitpod-io bot commented Feb 28, 2021 •
edited

@raisedadead raisedadead added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Feb 28, 2021
@ahmaxed
Copy link
Member

ahmaxed commented Mar 4, 2021

Screen Shot 2021-03-04 at 3 01 02 PM

Screen Shot 2021-03-04 at 3 01 12 PM

@ahmaxed
Copy link
Member

ahmaxed commented Mar 4, 2021

@tegardp, thanks for the PR :) This should resolve our issue with the translation cta button.

naomi-lgbt
naomi-lgbt approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Pulled down locally, got the same results as Ahmad's screenshots above. Appears to resolve the linked issue.

@naomi-lgbt naomi-lgbt merged commit 2630dc0 into freeCodeCamp:main Mar 4, 2021
@naomi-lgbt
Copy link
Member

Congrats on your first pull request (PR).

Thank you for your contribution to the page. We are happy to accept these changes and look forward to future contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmaxed ahmaxed ahmaxed approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'help us translate' badge link is breaking the layout on mobile/smaller screens
4 participants
@tegardp @ahmaxed @naomi-lgbt @raisedadead