Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(learn): rework Rosetta Code Harshad or Niven series #41554

Merged
merged 3 commits into from
Mar 25, 2021
Merged

fix(learn): rework Rosetta Code Harshad or Niven series #41554

merged 3 commits into from
Mar 25, 2021

Conversation

gikf
Copy link
Member

@gikf gikf commented Mar 22, 2021

  • Reworks challenge to use argument in function call. I've joined two parts of the original challenge - finding 20 numbers of sequence and first number greater than - into finding 10 numbers, starting from one greater than. Limiting required numbers to 10 allows to keep test descriptions cleaner, while not affecting difficulty of challenge.
  • Adds two tests.
  • Removes unnecessary link.
  • Changes tested on local fork.
  • Related to Rework coding interview prep challenges #40896.

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

@gitpod-io
Copy link

gitpod-io bot commented Mar 22, 2021 •
edited

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Mar 22, 2021
RandellDawson
RandellDawson previously requested changes Mar 22, 2021
View reviewed changes
Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggested change.

curriculum/challenges/english/10-coding-interview-prep/rosetta-code/harshad-or-niven-series.md Outdated Show resolved Hide resolved
@gikf @RandellDawson
fix: improve wording
4503805 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
naomi-lgbt
naomi-lgbt approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@naomi-lgbt naomi-lgbt enabled auto-merge (squash) March 23, 2021 15:52
@gikf gikf added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 25, 2021
@naomi-lgbt naomi-lgbt merged commit 8cc172d into freeCodeCamp:main Mar 25, 2021
@gikf gikf deleted the fix/rework-harshad-or-niven branch March 26, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raisedadead raisedadead raisedadead approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

@RandellDawson RandellDawson RandellDawson left review comments

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gikf @raisedadead @RandellDawson @naomi-lgbt