Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and move functions to tail #4407

Merged
merged 1 commit into from
Nov 13, 2015
Merged

Fix typo and move functions to tail #4407

merged 1 commit into from
Nov 13, 2015

Conversation

aulisius
Copy link
Contributor

Fixes #4399

I initially started to fix Waypoint: Reverse Arrays and moved the display function to the tail portion. Being a little bit enthusiastic, I moved all the display functions in the other Waypoints to the tail portion.

Note : Didn't test locally.

@ltegman
Copy link
Member

ltegman commented Nov 13, 2015

Unfortunately the tail calls are actually intentionally being left in the seed for these lessons because of #4228, which causes the page to lockup when a user creates the callback function if the tail call is not in the seed. For now would you mind reverting those changes and just fixing the typo? Sorry about that! Normally the enthusiasm would be well received but this darn bug keeps getting in the way.

@aulisius
Copy link
Contributor Author

But here, @SaintPeter told me I could move the display function to tail part. Or was it only for that challenge?

@ltegman
Copy link
Member

ltegman commented Nov 13, 2015

For now only that challenge, since reverse doesn't require typing function because there is no callback involved. All the other functional challenges do require typing function though and will lock up 😟

@aulisius
Copy link
Contributor Author

Hmm.. ok. Didn't think about that. Need to setup the dev env. soon instead of being ignorant :/ .

Will remove those changes and leave the reverse alone.

@ltegman
Copy link
Member

ltegman commented Nov 13, 2015

Awesome, thank you 😄 Getting FCC setup locally will definitely make things a lot easier on you. Feel free to hit me up on Gitter if you need any help setting it up.

ltegman added a commit that referenced this pull request Nov 13, 2015
@ltegman ltegman merged commit d71ad74 into freeCodeCamp:staging Nov 13, 2015
@aulisius aulisius deleted the fix/reverse-arrays-typo branch November 14, 2015 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants