Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordering spanish descriptions to follow changes in english #4449

Merged
merged 1 commit into from
Nov 16, 2015

Conversation

vtamara
Copy link
Member

@vtamara vtamara commented Nov 15, 2015

No description provided.

@bugron
Copy link
Contributor

bugron commented Nov 15, 2015

@vtamara why are you opening and closing your PRs?

@vtamara
Copy link
Member Author

vtamara commented Nov 15, 2015

Squashing didn't work first time.

Second time I found ortography error.

I hope this one is right

@bugron
Copy link
Contributor

bugron commented Nov 15, 2015

Please, make the changes in one PR, there is no need to open a new PR.
When you fix something in your PR just do git commit --amend to rewrite you last commit (or add a new commit instead) then perform force push to your fork: git push -f your_origin your_branch.

@vtamara
Copy link
Member Author

vtamara commented Nov 15, 2015

Thanks. If I find again the weird problems I had with the others PR, I will write you. Ok?

@vtamara vtamara changed the title Reordering first spanish descriptions to follow changes in english Reordering spanish descriptions to follow changes in english Nov 15, 2015
@QuincyLarson
Copy link
Contributor

Great work, @vtamara - I'm looking forward to talking with you about our Spanish translation effort.

QuincyLarson added a commit that referenced this pull request Nov 16, 2015
Reordering spanish descriptions to follow changes in english
@QuincyLarson QuincyLarson merged commit 99a565e into freeCodeCamp:staging Nov 16, 2015
@vtamara vtamara deleted the fix/spaord1 branch November 16, 2015 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants