Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish translation #4649

Merged
merged 1 commit into from
Dec 1, 2015
Merged

Add Spanish translation #4649

merged 1 commit into from
Dec 1, 2015

Conversation

Oxyrus
Copy link
Contributor

@Oxyrus Oxyrus commented Nov 22, 2015

Closes #4539

@bugron
Copy link
Contributor

bugron commented Nov 22, 2015

@Oxyrus thanks for the PR! Please change the description to Closes #4539 to auto close the issue when this PR will be merged. And next time, please, follow instruction from our Guidelines for Contributing, especially branch naming.

@Oxyrus
Copy link
Contributor Author

Oxyrus commented Nov 22, 2015

@bugron sorry, I edited the description, I'm not that good with GitHub yet 👍

],
[
"http://i.imgur.com/D7Y5luw.jpg",
"Una gráfica del crecimiento de trabajos en comparación con los graduados en un pregrado de ciencias de la computación. Hay 1.4 millones de empleos y solo 400 millones de personas para ocuparlos.",

This comment was marked as off-topic.

@vtamara
Copy link
Member

vtamara commented Nov 23, 2015

Good job with translation!

@davidojedalopez
Copy link
Contributor

Hi folks!

How can I help translating the site? I am native Spanish speaker and since I just started using GitHub, I think it is a way for me to learn how to work collaboratively.

@vtamara
Copy link
Member

vtamara commented Nov 23, 2015

Bienvenido @MEXshredder. Busca uno de los problemas (issues) pendientes en esta lista: https://github.com/FreeCodeCamp/FreeCodeCamp/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3Atranslation+spanish

Eliges uno, verificas que no tenga un comentario indicando que alguien está trabajando en ello, agregas un comentario que diga "Estoy trabjando en este" y empiezas a traducirlo.

@bugron
Copy link
Contributor

bugron commented Nov 27, 2015

@Oxyrus what's your progress on this?

@Oxyrus
Copy link
Contributor Author

Oxyrus commented Nov 27, 2015

@bugron I finished the translation and applied the conventions used for the language, do I have to create a new Pull Request?

I also created a new branch with a proper name for it, tell me what should I do now.

@bugron
Copy link
Contributor

bugron commented Nov 27, 2015

@Oxyrus you should git commit --amend your commit in this branch, there is no need to create a new branch or new PR.

@jbmartinez
Copy link
Contributor

I have a comment about the suggested translation of chat to Spanish. When someone talks me about "teleconferencia" I think of Skype, not Gitter. And I'm sure I'm not the only one.

@Oxyrus
Copy link
Contributor Author

Oxyrus commented Nov 28, 2015

@bugron Awesome, the PR is updated with the new file!

@jbmartinez we are not going to use "teleconferencia", we're going to stick with Chat.

@Oxyrus
Copy link
Contributor Author

Oxyrus commented Nov 29, 2015

@vtamara ¿podrías echar un vistazo para saber si la traducción esta correcta ahora?

@vtamara
Copy link
Member

vtamara commented Nov 30, 2015

Sigue pendiente cambiar 400 millones por 400 miles en la línea 85.

El de la línea 104 me parece que debe arreglarse, puede ser con mi sugerencia "Tras unas 400 horas en ..."

En la 415 sigue pendiente cambiar "Pregunta por ayuda" por ejemplo por "Pide ayuda"

@bugron
Copy link
Contributor

bugron commented Dec 1, 2015

@Oxyrus @vtamara is this ready to be merged?

@vtamara
Copy link
Member

vtamara commented Dec 1, 2015

Yes, we agred with Quincy to merge the whole spanish translation and micro-manage corrections after.

@ltegman
Copy link
Member

ltegman commented Dec 1, 2015

Thanks again! 😄

ltegman added a commit that referenced this pull request Dec 1, 2015
@ltegman ltegman merged commit eba5ddb into freeCodeCamp:staging Dec 1, 2015
@Oxyrus Oxyrus deleted the patch-1 branch December 2, 2015 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants