-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test to fail on incorrect input #5007
Fix test to fail on incorrect input #5007
Conversation
Don't you need to do the prior test as well as the new test? It looks like you're testing to make sure it's in a button, but now it could be any button, not just the |
I'm checking the button of a class |
Agreed with @SaintPeter. We need both of these tests. You can combine them: |
@LenaBarinova OK, but now your second test checks for the
and then force push your branch to your fork: |
I've appended the test, didn't create new one, since we are checking the same logical thing - |
@LenaBarinova oh, yes, sorry, my fault. |
…ns to our Buttons Added more precise checking for not only class of the button but also text
@LenaBarinova I've verified that this works. After you squash your commits into one I'm ready to merge your PR. |
09343f0
to
0b48d7e
Compare
…passes-the-test Fix test to fail on incorrect input
@bugron all done! |
@bugron Thanks for the help! It was first commit, I hope further commits will go more smoothly :) |
In 'Waypoint: Add Font Awesome Icons to our Buttons' challenge changed a test to check whether element is within Like button (did it the same way as it is done in 'Waypoint: Add Font Awesome Icons to all of our Buttons' challenge).
closes #4981