Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Components] Update the CSS of hover and focus states of CloseButton #54011

Closed
huyenltnguyen opened this issue Mar 7, 2024 · 6 comments · Fixed by #54029
Closed

[UI Components] Update the CSS of hover and focus states of CloseButton #54011

huyenltnguyen opened this issue Mar 7, 2024 · 6 comments · Fixed by #54029
Labels
help wanted Open for all. You do not need permission to work on these. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. scope: UI Threads for addressing UX changes and improvements to user interface

Comments

@huyenltnguyen
Copy link
Member

Description

The CloseButton component of ui-components is missing hover and focus styles. We would like to add them in so that we can replicate the current display in /learn.

Comparison:

ui-components /learn
close-button learn-close-button

Requirements

  • Add hover and focus styles to the CloseButton component
  • Remove the close class from the CloseButton component in Flash, and ensure that the change doesn't introduce any visual regression:
    <CloseButton
    onClick={handleClose}
    label={t('buttons.close')}
    className='close'

Relevant files:

@huyenltnguyen huyenltnguyen added help wanted Open for all. You do not need permission to work on these. scope: UI Threads for addressing UX changes and improvements to user interface scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Mar 7, 2024
@Amrani-Farouk-Hossam-Eddine

Hi, i'm interesting in this issue if there is no currenlty working on it

@huyenltnguyen
Copy link
Member Author

@Amrani-Farouk-Hossam-Eddine Issues labeled with help wanted are up for grabs, so feel free to work on this if you're interested.

Be sure you read our guidelines for contributing as well as our expectations from a pull request, we prioritize contributors following the instructions in our guides. Join us in our chat room or our forum if you need help contributing; our moderators will guide you through this.

Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first.

Happy contributing.

@sarmadH97
Copy link

Hi @Amrani-Farouk-Hossam-Eddine, Did you start working on it ?

@Amrani-Farouk-Hossam-Eddine

Hi @Amrani-Farouk-Hossam-Eddine, Did you start working on it ?

to be completly honest with you i really want to contribute to freeCodeCamp and i got lost in the guide and i need some help if you already familuar with it

@sarmadH97
Copy link

I'm new to this too, I'll let you know if i figure it out

@Amrani-Farouk-Hossam-Eddine

i worked on it and i made a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. scope: UI Threads for addressing UX changes and improvements to user interface
Projects
None yet
3 participants