Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protein grams position on Nutrition Label. Step 61+. #54160

Closed
hattiza opened this issue Mar 21, 2024 · 0 comments · Fixed by #54165
Closed

Protein grams position on Nutrition Label. Step 61+. #54160

hattiza opened this issue Mar 21, 2024 · 0 comments · Fixed by #54165
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: PR in works Work in Progress (WIP) Issues. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@hattiza
Copy link
Sponsor

hattiza commented Mar 21, 2024

Describe the Issue

There are two issues:

  1. The positioning of grams on the protein line is in the percent "column" which looks strange and does not follow the FDA guidelines.

Here is the FCC challange:
fcc_protein

And the FDA guidlines
fda_protein

  1. The code can be passed with either the FCC version or the FDA version.

FDA guidline: https://www.fda.gov/media/135197/download?attachment

Affected Page

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-typography-by-building-a-nutrition-label/step-61

Your code

<p class="no-divider"><span><span class="bold">Protein</span> 3g</span></p>

or

<p class="no-divider"><span class="bold">Protein</span> 3g</p>

Expected behavior

Should look like FDA rules and/or pass with only one version.

  • Both snippets pass the tests
  • When snippet 1 (following FDA guidelines) is used, the next step resets the code to snippet 2
    passing-with-FDA

Screenshots

No response

System

  • Device: N/A
  • OS: N/A
  • Browser: N/A
  • Version: N/A

Additional context

No response

@hattiza hattiza added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. labels Mar 21, 2024
@huyenltnguyen huyenltnguyen added status: PR in works Work in Progress (WIP) Issues. and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: PR in works Work in Progress (WIP) Issues. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants