Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test too strict in step 27 of Luhn Algorithm project #54506

Closed
Dario-DC opened this issue Apr 23, 2024 · 0 comments · Fixed by #54508
Closed

Test too strict in step 27 of Luhn Algorithm project #54506

Dario-DC opened this issue Apr 23, 2024 · 0 comments · Fixed by #54508
Labels
help wanted Open for all. You do not need permission to work on these. new python course scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@Dario-DC
Copy link
Contributor

Describe the Issue

The test for this step requires to add spaces around the comparison operator:

if number >= 10:
    print(number)

Affected Page

https://www.freecodecamp.org/learn/scientific-computing-with-python/learn-how-to-work-with-numbers-and-strings-by-implementing-the-luhn-algorithm/step-27

Your code

if number>=10:
    print(number)

Expected behavior

The test should pass even when there's no space around >=.

Screenshots

No response

System

  • Device: [e.g. iPhone 6, Laptop]
  • OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
  • Browser: [e.g. Chrome, Safari]
  • Version: [e.g. 22]

Additional context

It would be nice to rewrite the test using the new ast-based helpers.

@Dario-DC Dario-DC added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. new python course and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. new python course scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
1 participant