Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waypoint: Concatenating Strings with Plus Operator [Beta] grammar #5490

Closed
HermanFassett opened this issue Dec 28, 2015 · 4 comments
Closed
Assignees

Comments

@HermanFassett
Copy link

In JavaScript, the + operator when used with a String value, it is called concatenation operator.

Grammatically speaking this should probably read something more like

In JavaScript, the + operator when used with a String value is called the concatenation operator.

@HermanFassett HermanFassett changed the title Waypoint: Concatenating Strings with Plus Operator [Beta] Waypoint: Concatenating Strings with Plus Operator [Beta] grammar Dec 28, 2015
@CaroleAnneHannon
Copy link
Contributor

Adding another one to this:

The first test says
myStr should have a value of This is the start. This is the end

but it only accepts a value of This is the start. This is the end.

so I think it's missing a period in the test directions

Also it shows undefined in the viewer

@SaintPeter SaintPeter self-assigned this Dec 28, 2015
@abhisekp
Copy link
Member

@HermanFassett I think the earlier statement

"In JavaScript, the + operator when used with a String value, it is called concatenation operator."

is better to understand.

@HermanFassett
Copy link
Author

@abhisekp but it is incorrect English.

SaintPeter pushed a commit that referenced this issue Dec 28, 2015
@SaintPeter
Copy link
Member

Updated:
image

@SaintPeter SaintPeter added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 28, 2015
@ltegman ltegman closed this as completed Dec 28, 2015
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants