Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack trace error in javascript challenge #5642

Merged
merged 1 commit into from Dec 31, 2015

Conversation

DDaems
Copy link
Contributor

@DDaems DDaems commented Dec 31, 2015

  • added a additional check to make sure the function exists

close #5560

- added a additional check to make sure the function exists
@KrisVos130
Copy link

This shouldn't fix #5560 since that error still displays even if you don't modify anything and click submit or when you add myFunction and it actually is a function.

@DDaems
Copy link
Contributor Author

DDaems commented Dec 31, 2015

I tested thoroughly on my local copy, Is this based on a hunch? Sinds i can't seem to reproduce what you are saying. Did you test my changes?

@KrisVos130

@ShaggyTech
Copy link
Contributor

@DDaems I tested your changes on my local copy and can confirm that this fixes #5560

@ltegman
Copy link
Member

ltegman commented Dec 31, 2015

Woot! Good work getting to the bottom of this! 👍

@ltegman ltegman closed this Dec 31, 2015
@ltegman ltegman reopened this Dec 31, 2015
ltegman added a commit that referenced this pull request Dec 31, 2015
Fix stack trace error in javascript challenge
@ltegman ltegman merged commit 09d5a7d into freeCodeCamp:staging Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants