Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5628 - Remove unwanted test case #5669

Merged
merged 1 commit into from
Dec 31, 2015
Merged

Fix #5628 - Remove unwanted test case #5669

merged 1 commit into from
Dec 31, 2015

Conversation

smrajagopal
Copy link
Contributor

Removed test case requiring only 5 'return' statements
be used in 'Waypoint: Chaining If Else Statements'

npm run test-challenges returned Pass also tested locally.

image

@smrajagopal
Copy link
Contributor Author

Well, I will close this PR. Because two of us worked at the same time and this PR was created a minute later one another one which should be merged.

@smrajagopal smrajagopal reopened this Dec 31, 2015
@ltegman
Copy link
Member

ltegman commented Dec 31, 2015

Please put closes #5628 in the body of your PR so that the issue will be autoclosed when this is accepted. Also, per @SaintPeter's request in that thread could you just change this test to check for > 5 rather than remove it? After you make this change you can git add . && git commit --amend && git push -f to amend this commit and force push the change to this PR. Thanks! 😄

@smrajagopal
Copy link
Contributor Author

@ltegman
I accidentally closed this one instead of closing the other duplicate PR

This one is all good to proceed with review by FCC Collaborator.

@smrajagopal smrajagopal force-pushed the fix/5628_remove_unwanted_test_case branch 2 times, most recently from 5983b1e to 63f324c Compare December 31, 2015 23:11
@smrajagopal
Fix freeCodeCamp#5628 - Update test case to fix logic around return s…
63f324c 
…tatements

Fixed test case to allow 5 or more 'return' statements
to be used in 'Waypoint: Chaining If Else Statements'
@smrajagopal
Copy link
Contributor Author

@ltegman
Fixed in 63f324c
closes #5628

@ltegman
Copy link
Member

ltegman commented Dec 31, 2015

You have to edit the main message of your PR for it to close the issue, but I'll just close it myself this time. This PR looks good now, thanks!

ltegman added a commit that referenced this pull request Dec 31, 2015
@ltegman
Merge pull request #5669 from smrajagopal/fix/5628_remove_unwanted_te…
495448f 
…st_case

Fix #5628 - Remove unwanted test case
@ltegman ltegman merged commit 495448f into freeCodeCamp:staging Dec 31, 2015
@gayfordjames
Copy link

Started today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smrajagopal @ltegman @gayfordjames