Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions and tests of change font-size challenge #6864

Conversation

ankitaggarwal011
Copy link
Contributor

Update instructions and test cases of Challenge Change the Font Size of an Element.

closes #6819.

@bugron bugron added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 10, 2016
@@ -477,7 +477,7 @@
"<blockquote>h1 {<br>&nbsp;&nbsp;font-size: 30px;<br>}</blockquote>",
"Create a second <code>p</code> element with the following kitty ipsum text: <code>Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.</code>",
"Inside the same <code>&#60;style&#62;</code> tag that contains your <code>red-text</code> class, create an entry for <code>p</code> elements and set the <code>font-size</code> to 16 pixels (<code>16px</code>).",
"<strong>Note</strong><br>Due to browser implementation differences, you may need to be at 100% zoom to pass the tests on this challenge.<br>Also, please do not add any extra classes to your new element."
"<strong>Note</strong><br>Due to browser implementation differences, you may need to be at 100% zoom to pass the tests on this challenge.<br><br>Also, please do not add class attribute to your new <code>p</code> element."

This comment was marked as off-topic.

This comment was marked as off-topic.

@SaintPeter
Copy link
Member

Aside from the above notes, I tested this and it works well. You can git commit --amend to update this PR - just do a git push -f to update it.

@ankitaggarwal011 ankitaggarwal011 force-pushed the fix/update-instructions-tests-of-challenge branch from 5b117ba to 9a34611 Compare February 11, 2016 04:47
@ankitaggarwal011
Copy link
Contributor Author

@SaintPeter, Done! Thanks for the help.

@QuincyLarson
Copy link
Contributor

@ankitaggarwal011 thanks for your contribution. This works great!

QuincyLarson added a commit that referenced this pull request Feb 12, 2016
…s-tests-of-challenge

Update instructions and tests of change font-size challenge
@QuincyLarson QuincyLarson merged commit 9e85cd3 into freeCodeCamp:staging Feb 12, 2016
@QuincyLarson QuincyLarson removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 12, 2016
@ankitaggarwal011 ankitaggarwal011 deleted the fix/update-instructions-tests-of-challenge branch February 12, 2016 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants