Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit ES Translation of object-oriented-and-functional-programming.json #7036

Conversation

justinian336
Copy link
Contributor

Closes #6506

@bugron bugron added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 15, 2016
@vtamara
Copy link
Member

vtamara commented Feb 17, 2016

@bugron I don't have so much time to review all the pull request related to spanish. Besides the process we have suggested from the spanish team is to announce in the channel for the spanish translators to review when a translator finishes a translation. I already announced there about this PR. @justinian336 thank you for your work, please when you send a PR translating to spanish announce in the channel for spanish translators.

@justinian336
Copy link
Contributor Author

@vtamara sorry that I forgot to announce it to the others! I'll do it next time.

@vtamara
Copy link
Member

vtamara commented Feb 17, 2016

Reviewed. Thanks @justinian336, good job. @bugron thanks for your work. It is possible to merge.

@bugron
Copy link
Contributor

bugron commented Feb 17, 2016

@justinian336 @vtamara thanks, merged.

bugron added a commit that referenced this pull request Feb 17, 2016
…ject-oriented-and-functional-programming.json

Audit ES Translation of object-oriented-and-functional-programming.json
@bugron bugron merged commit 32aa732 into freeCodeCamp:staging Feb 17, 2016
@bugron bugron removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants