Fix tests for Change text with Click Events #7361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BerkeleyTrue
added
the
status: waiting review
| @@ -108,7 +108,7 @@ | |||
| "</div>" | |||
| ], | |||
| "tests": [ | |||
| "assert(code.match(/\\$\\s*?\\(\\s*?(?:'|\")\\.message(?:'|\")\\s*?\\)\\s*?\\.html\\s*?\\(\\s*?(?:'|\")Here\\sis\\sthe\\smessage(?:'|\")\\s*?\\);/gi), 'message: Clicking the \"Get Message\" button should give the element with the class <code>message</code> the text \"Here is the message\".');" | |||
| "assert(code.match(/\\$\\s*?\\(\\s*?(?:'|\")\\.message(?:'|\")\\s*?\\)\\s*?\\.html|.text\\s*?\\(\\s*?(?:'|\")Here\\sis\\sthe\\smessage(?:'|\")\\s*?\\);/gi), 'message: Clicking the \"Get Message\" button should give the element with the class <code>message</code> the text \"Here is the message\".');" | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This commit adds checks to alow `.text` along with `.html`, as per the discussion in the issue.
|
@raisedadead updated the pull request. |
|
@SaintPeter this one is good to go! Please have a look. |
|
👍 |
ltegman
added a commit
that referenced
this pull request
Mar 6, 2016
…events Fix tests for Change text with Click Events
BerkeleyTrue
removed
the
status: waiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds checks to alow
.textalong with.html,as per the discussion in the issue.
Tested locally.
Closes #7319