Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/FR translation responsive design with bootstrap #7625

Merged
merged 1 commit into from Mar 21, 2016
Merged

Add/FR translation responsive design with bootstrap #7625

merged 1 commit into from Mar 21, 2016

Conversation

N0bl3
Copy link
Contributor

@N0bl3 N0bl3 commented Mar 19, 2016

Translation of bootstrap challenges in french.
closes #7532

@camperbot
Copy link
Contributor

@N0bl3 thanks for the PR.
Your branch name should start with one of fix/, feature/, translate/ prefixes. Name, your branches correctly next time, please.
Please, review our Guidelines for Contributing, thank you!.

@ghost
Copy link

ghost commented Mar 19, 2016

closes #7625

@bugron bugron added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 20, 2016
@camperbot
Copy link
Contributor

@N0bl3 updated the pull request.

2 similar comments
@camperbot
Copy link
Contributor

@N0bl3 updated the pull request.

@camperbot
Copy link
Contributor

@N0bl3 updated the pull request.

@N0bl3
Copy link
Contributor Author

N0bl3 commented Mar 21, 2016

Much better. Now the PR is clean.

@AkiraLaine
Copy link
Member

@theflametrooper @N0bl3 This looks good to me. I can wait for @fnonga to QA before merging if you want.

@ghost
Copy link

ghost commented Mar 21, 2016

Nah, go ahead! I've already verified it in google translate and its fine.

AkiraLaine pushed a commit that referenced this pull request Mar 21, 2016
…tstrap

Add/FR translation responsive design with bootstrap
@AkiraLaine AkiraLaine merged commit b2e5057 into freeCodeCamp:staging Mar 21, 2016
@AkiraLaine
Copy link
Member

Thanks a ton @N0bl3

@ghost
Copy link

ghost commented Mar 21, 2016

@N0bl3 Thanks for helping!

@cploose
Copy link

cploose commented Mar 21, 2016

good work, thanks !

@ghost
Copy link

ghost commented Mar 21, 2016

closes #7625

@sbter79
Copy link

sbter79 commented Mar 28, 2016

#7631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants