Fixes RegExp so it matches the class .blue-text #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@treece Thanks for the PR! The switch to regex literal should remove the regex constructor. Otherwise it looks like a code small. Either use a constructor with string arguments or use just the literal. |
BerkeleyTrue
added
status: waiting review
|
@BerkeleyTrue Thanks for letting me know! I confused myself with the ECMAScript 6 changes and the TypeError object. Does my latest commit fix it? |
|
This looks good to me. I'll verify it works before pushing to production. |
QuincyLarson
pushed a commit
that referenced
this pull request
Jun 8, 2015
Fixes RegExp so it matches the class .blue-text
QuincyLarson
removed
the
status: waiting review
This was referenced Oct 19, 2020
This was referenced Apr 26, 2021
This was referenced Apr 27, 2021
This was referenced Oct 5, 2022
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #841
The current expression on the site now works but the dot/period isn't escaped which is causing the challenge to pass that step if any characters (except line breaks) are in front of the word "blue-text"
So to fix this I just escaped the dot/period and changed the format to literal notation.